[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820

MananTank · 2024-12-20T11:39:21Z

Problem solved

Problem:

User uploads a CSV1 and then uploads a CSV2 - CSV2 is ignored and CSV1's data is sent instead of CSV2 because of incorrect query cache key

PR-Codex overview

This PR focuses on improving the handling of queries in the useCsvUpload hook by changing the mapping of rawData to use a more descriptive variable name and ensuring the correct item is passed to the checkIsAddress function.

Detailed summary

Changed the variable name in the map function from o to item for clarity.
Updated the queryKey to use item directly instead of o.address.
Ensured the queryFn passes the correct item to checkIsAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-20T11:39:25Z

TOOL-2773 Allowlist csv file bulk application issue in NFT ClaimConditions

vercel · 2024-12-20T11:39:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 0:23am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 20, 2024 0:23am
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 20, 2024 0:23am
wallet-ui	⬜️ Skipped (Inspect)	Dec 20, 2024 0:23am

changeset-bot · 2024-12-20T11:39:26Z

⚠️ No Changeset found

Latest commit: cb66be4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2024-12-20T11:39:39Z

[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

apps/dashboard/src/hooks/useCsvUpload.ts

codecov · 2024-12-20T11:41:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (cfbe8c3) to head (cb66be4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5820   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4825     4825           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from cfbe8c3
packages	`50.56% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-20T11:42:57Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.02 KB (0%)	901 ms (0%)	3.1 s (+55.04% 🔺)	4 s
thirdweb (cjs)	110.76 KB (0%)	2.3 s (0%)	6.6 s (-8.39% 🔽)	8.8 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	372 ms (+57.76% 🔺)	484 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	85 ms (+23.87% 🔺)	95 ms
thirdweb/react (minimal + tree-shaking)	19.1 KB (0%)	383 ms (0%)	680 ms (-12.09% 🔽)	1.1 s

apps/dashboard/src/hooks/useCsvUpload.ts

kien-ngo

lgtm

graphite-app · 2024-12-20T12:19:24Z

Merge activity

Dec 20, 7:19 AM EST: A user added this pull request to the Graphite merge queue.
Dec 20, 7:23 AM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Fixes: #5791 Problem: User uploads a CSV1 and then uploads a CSV2 - CSV2 is ignored and CSV1's data is sent instead of CSV2 because of incorrect query cache key  --- ## PR-Codex overview This PR focuses on refactoring the `normalizeQuery` in the `useCsvUpload` hook to improve clarity and consistency in parameter naming. ### Detailed summary - Changed the parameter name from `o` to `item` in the `rawData.map` function for better readability. - Updated the `queryKey` to use `item` directly instead of `o.address`. - Maintained the same functionality while enhancing code clarity. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 11:39 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 11:39 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 11:39 Inactive

MananTank marked this pull request as ready for review December 20, 2024 11:39

MananTank requested review from a team and jakubkrehel as code owners December 20, 2024 11:39

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 20, 2024

github-actions bot assigned MananTank Dec 20, 2024

graphite-app bot reviewed Dec 20, 2024

View reviewed changes

apps/dashboard/src/hooks/useCsvUpload.ts Show resolved Hide resolved

vercel bot deployed to Preview – thirdweb-www December 20, 2024 11:49 View deployment

kien-ngo reviewed Dec 20, 2024

View reviewed changes

apps/dashboard/src/hooks/useCsvUpload.ts Show resolved Hide resolved

kien-ngo self-requested a review December 20, 2024 12:18

kien-ngo approved these changes Dec 20, 2024

View reviewed changes

MananTank force-pushed the 12-20-_tool-2773_fix_incorrect_caching_in_usecsvupload_hook branch from 453c180 to cb66be4 Compare December 20, 2024 12:20

vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 12:20 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 12:20 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 12:20 Inactive

vercel bot deployed to Preview – thirdweb-www December 20, 2024 12:23 View deployment

graphite-app bot merged commit cb66be4 into main Dec 20, 2024
31 checks passed

graphite-app bot deleted the 12-20-_tool-2773_fix_incorrect_caching_in_usecsvupload_hook branch December 20, 2024 12:23

vercel bot temporarily deployed to Production – wallet-ui December 20, 2024 12:23 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground December 20, 2024 12:23 Inactive

vercel bot temporarily deployed to Production – docs-v2 December 20, 2024 12:23 Inactive

vercel bot deployed to Production – thirdweb-www December 20, 2024 12:31 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820

[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820

Uh oh!

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

vercel bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

MananTank commented Dec 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

kien-ngo left a comment

Uh oh!

graphite-app bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820

[TOOL-2773] Fix incorrect caching in useCsvUpload hook #5820

Uh oh!

Conversation

MananTank commented Dec 20, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

vercel bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

codecov bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

kien-ngo left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

changeset-bot bot commented Dec 20, 2024 •

edited

Loading

MananTank commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading